Review Request 126185: Make the KAppTemplate CMake module global
Marco Martin
notmart at gmail.com
Tue Dec 15 10:38:49 UTC 2015
> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote:
> > Ooh, also, please write a unit test. I can help with that if you find the idea of writing a CMake-based unit test daunting, but you can look in the tests directory for inspiration.
I'm not sure what the test should do...
perhaps having in the repo a tarball and a source template, make it generate and then compare the files?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review89391
-----------------------------------------------------------
On Dec. 15, 2015, 10:38 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 10:38 a.m.)
>
>
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake b7cd34d
> kde-modules/KDETemplateGenerator.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
>
>
> Testing
> -------
>
> done some templates installed by plasma-framework
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151215/fcd2a836/attachment.html>
More information about the Kde-buildsystem
mailing list