Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter

Dominik Schmidt kde at dominik-schmidt.de
Thu Dec 10 18:28:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/
-----------------------------------------------------------

(Updated Dez. 10, 2015, 6:28 nachm.)


Review request for Extra Cmake Modules.


Repository: extra-cmake-modules


Description
-------

On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is the autogenerated name for our sources variable, thus I added an optional paramater allowing to override the basename (without extension).


Diffs
-----

  modules/ECMAddAppIcon.cmake f90d4c3 

Diff: https://git.reviewboard.kde.org/r/126303/diff/


Testing (updated)
-------

Tested it in Tomahawk and it works.

Actually, something is fishy. Still investigating.


Thanks,

Dominik Schmidt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151210/4ba9f6f2/attachment.html>


More information about the Kde-buildsystem mailing list