[plasma-framework] /: Add KDETemplateMacro.cmake so I can remove it from ecm for now.

[Alex Merry]

On 3 December 2015 12:35:59 GMT+00:00, Marco Martin <notmart at gmail.com> wrote:
>On Thursday 03 December 2015, Alex Merry wrote:
>> Sorry, I did reply to your commit email directly, but didn't get a
>response
>> from you, and then ran out of time. I have no objection to ecm having
>a
>
>ok, sorry, I didn't see the email, must got filtered out
>
>> macro like this, but the module wasn't up to scratch for ecm, and
>once
>> it's in a release, we can't break compatibility. Given the module
>name was
>> one of the things I wasn't happy with, keeping it out of this
>weekend's
>> release was a priority for me.
>> 
>> ECM discussions don't need to be global, but kde-buildsystem should
>really
>> be involved.
>> 
>> Can we revisit adding this to ecm next week?
>
>ok, sure! 
>I've reopened https://git.reviewboard.kde.org/r/126185/
>and added the buildsystem group to it.
>Then we can discuss there the changes to be done. (or if you prefer a
>thread 
>in the builsystem ml)
>
>-- 
>Marco Martin

Thanks. I'll look at that RR next week. Sorry again for the way I did this - I don't like reverting other people's commits, but I was out of time, and I don't have my laptop with me this weekend.

Alex

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151203/8f32ac24/attachment.html>