Review Request 124595: Add macro to generate logging category declarations for Qt5.

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124595/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 9:34 p.m.)


Review request for Extra Cmake Modules and David Faure.


Changes
-------

Fix issues spotted by Alex Richardson.


Repository: extra-cmake-modules


Description
-------

This makes life a bit easier for developers who use the categorised
logging in Qt5 in the common case - rather than creating two new files,
and remembering to put in the #ifdef for the default verbosity settings
in Qt 5.4, they can just add a couple of lines to their CMakeLists.txt.

(NB: see https://codereview.qt-project.org/#/c/122641 for patch for the Qt bug mentioned in the docs).


Diffs (updated)
-----

  tests/ECMQtDeclareLoggingCategoryTest/testmain.cpp PRE-CREATION 
  tests/ECMQtDeclareLoggingCategoryTest/CMakeLists.txt PRE-CREATION 
  tests/CMakeLists.txt 7960154a42ec083be61aec2bd066b072560beb61 
  modules/ECMQtDeclareLoggingCategory.h.in PRE-CREATION 
  modules/ECMQtDeclareLoggingCategory.cpp.in PRE-CREATION 
  docs/module/ECMQtDeclareLoggingCategory.rst PRE-CREATION 
  modules/ECMQtDeclareLoggingCategory.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124595/diff/


Testing
-------

Added unit test runs and passes. Documentation builds and looks sane.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150816/a8dfe7be/attachment-0001.html>