Review Request 124762: KDEFrameworkCompilerSettings: only enable strict iterators in debug mode

Alex Merry alex.merry at kde.org
Sun Aug 16 09:53:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124762/#review83862
-----------------------------------------------------------

Ship it!


But you should also mention in the commit message that it will now also apply to MSVC.

- Alex Merry


On Aug. 15, 2015, 11:17 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124762/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 11:17 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> (they are slower)
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEFrameworkCompilerSettings.cmake 1bc23ccf8e8a54d3c6153ad6c999d41e31e64417 
> 
> Diff: https://git.reviewboard.kde.org/r/124762/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150816/dc8b2374/attachment.html>


More information about the Kde-buildsystem mailing list