Review Request 124610: do not install namelink for private library

Harald Sitter sitter at kde.org
Wed Aug 12 06:06:33 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124610/
-----------------------------------------------------------

(Updated Aug. 12, 2015, 6:06 a.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo, Build System and KDE Frameworks.


Changes
-------

Submitted with commit 9807ff7416f651a0daf289b7bd024a7bb9952f99 by Harald Sitter to branch master.


Repository: baloo


Description
-------

please note that the private target is appearing in the resulting cmake
config all the same and we cannot prevent this because of a cmake oddity
Alex Merry was kind enough to track down [1].
testing suggests that this is however not breaking anything (what with the
library being private).

[1] http://public.kitware.com/pipermail/cmake-developers/2015-July/025798.html


Diffs
-----

  src/engine/CMakeLists.txt 8e2b5b9c0294a08142f4dc486eecab442167b1ec 

Diff: https://git.reviewboard.kde.org/r/124610/diff/


Testing
-------

make && make install
  no .so symlink installed

made sure there is no symlink on the system and rebuilt gwenview:
  gwenview builds just fine


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150812/4d24eb01/attachment.html>


More information about the Kde-buildsystem mailing list