Review Request 124613: kdesrc-build: improve message about why a full refresh is needed

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124613/#review83595
-----------------------------------------------------------



modules/ksb/BuildSystem.pm (line 73)
<https://git.reviewboard.kde.org/r/124613/#comment57852>

    Are you sure? I found code in Module.pm line 509 that creates a .refresh-me file right after printing out "Unable to configure".



modules/ksb/BuildSystem.pm (line 79)
<https://git.reviewboard.kde.org/r/124613/#comment57854>

    what does // 0 mean btw?



modules/ksb/BuildSystem.pm (line 82)
<https://git.reviewboard.kde.org/r/124613/#comment57853>

    Well, either that or the user manually wiped out the contents of the builddir (but not the builddir itself).
    (or kdesrc-build looks for the wrong file, in case of a bug).
    
    I'd like to keep the output as precise as possible, so one can figure out why exactly this is happening...


- David Faure


On Aug. 4, 2015, 9:57 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124613/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 9:57 a.m.)
> 
> 
> Review request for Build System and Michael Pyne.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> i.e. be more precise than "meets other building criteria"
> 
> 
> Diffs
> -----
> 
>   modules/ksb/BuildSystem.pm 24963040d77dc93f8f86a2f19755c617713bbd8a 
>   modules/ksb/IPC.pm 0e55c5fe5c2a8771f6b9b159a684bdcc6dda52a7 
>   modules/ksb/Module.pm a7a7fbcc5e30cbb4c52979d87407a3250b80f2b2 
> 
> Diff: https://git.reviewboard.kde.org/r/124613/diff/
> 
> 
> Testing
> -------
> 
> Example:
> 
> $ kdesrc-build --refresh plasma-nm
> 
> Building plasma-nm from kf5-network-management (1/1)
>         Updating plasma-nm (to branch master)
>         No source update, but the option refresh-build was set
>         Source update complete for plasma-nm: no files affected
>         Preparing build system for plasma-nm.
> ...
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150809/483ddd3b/attachment.html>