Review Request 124610: do not install namelink for private library

[Harald Sitter]

> On Aug. 4, 2015, 8:39 a.m., Vishesh Handa wrote:
> > I have no idea what this does. Someone else will need to give it a ShipIt. Also, you probably want to get this in today before the tagging.

Actually I'd rather put it in after tagging so we get a month worth of CI on top of the change. KGlobalAccel has the same problem and was released with it, so I suppose we can live with the .so symlinks for another month to make sure nothing breaks.
Since the libs are not considered public and cannot be linked against unless one actually copies the headers from the framework source the symlink on its own doesn't cause immediate concern anyway.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124610/#review83412
-----------------------------------------------------------


On Aug. 4, 2015, 8:04 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124610/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 8:04 a.m.)
> 
> 
> Review request for Baloo, Build System and KDE Frameworks.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> please note that the private target is appearing in the resulting cmake
> config all the same and we cannot prevent this because of a cmake oddity
> Alex Merry was kind enough to track down [1].
> testing suggests that this is however not breaking anything (what with the
> library being private).
> 
> [1] http://public.kitware.com/pipermail/cmake-developers/2015-July/025798.html
> 
> 
> Diffs
> -----
> 
>   src/engine/CMakeLists.txt 8e2b5b9c0294a08142f4dc486eecab442167b1ec 
> 
> Diff: https://git.reviewboard.kde.org/r/124610/diff/
> 
> 
> Testing
> -------
> 
> make && make install
>   no .so symlink installed
> 
> made sure there is no symlink on the system and rebuilt gwenview:
>   gwenview builds just fine
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150804/08cf582e/attachment-0001.html>