Review Request 123491: Add a test that checks the modules we're depending on exist

[Albert Astals Cid]

> On abr. 24, 2015, 3:49 p.m., Kevin Funk wrote:
> > modules/ECMGeneratePriFile.cmake, line 180
> > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180>
> >
> >     Just tested the patch myself on sonnet.
> >     
> >     The test indeed breaks if sonnet is not installed beforehand. But I agree, that's probably not a big issue since we usually have to install before running `make test`.
> >     
> >     Not having the right `QMAKEPATH` set during the test run imposes another burden on the user, however.
> >     
> >     What about adding:
> >     ```
> >     set_tests_properties(... PROPERTIES
> >       ENVIRONMENT
> >         QMAKEPATH=${qt_host_data_dir}
> >     ```
> 
> Kevin Funk wrote:
>     Err, wrong. I meant `QMAKEPATH=${CMAKE_INSTALL_PREFIX}`. This is the case where it breaks, of course.

don't think we should workaround the user having the wrong environment, we're getting the qmake path from another ecm module, so either fix that one or accept your env is broken :D


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79460
-----------------------------------------------------------


On abr. 24, 2015, 3:26 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123491/
> -----------------------------------------------------------
> 
> (Updated abr. 24, 2015, 3:26 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do some sanity checking on the dependencies we're declaring
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/123491/diff/
> 
> 
> Testing
> -------
> 
> Ran make test in ktextwidgets without http://quickgit.kde.org/?p=ktextwidgets.git&a=commitdiff&h=b83617d59b14941b1e26d295e9ea300301365321 and it correctly failed.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150424/b70f3804/attachment.html>