Review Request 123491: Add a test that checks the modules we're depending on exist

[Albert Astals Cid]

> On abr. 24, 2015, 3:36 p.m., Alex Merry wrote:
> > modules/ECMGeneratePriFile.cmake, lines 178-180
> > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178>
> >
> >     I think there should be an argument that could be passed to disable this (NO_TESTS?). Not all downstream users may want such a test.

Why wouldn't you want a test that checks that your .pri is not broken?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79458
-----------------------------------------------------------


On abr. 24, 2015, 3:26 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123491/
> -----------------------------------------------------------
> 
> (Updated abr. 24, 2015, 3:26 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do some sanity checking on the dependencies we're declaring
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/123491/diff/
> 
> 
> Testing
> -------
> 
> Ran make test in ktextwidgets without http://quickgit.kde.org/?p=ktextwidgets.git&a=commitdiff&h=b83617d59b14941b1e26d295e9ea300301365321 and it correctly failed.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150424/83ad9993/attachment-0001.html>