Review Request 122501: Do not call lrelease with -compress because it has some long-standing issues
Aurélien Gâteau
agateau at kde.org
Thu Apr 9 07:58:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122501/#review78694
-----------------------------------------------------------
Ship it!
Ship It!
- Aurélien Gâteau
On avr. 9, 2015, 2:03 matin, Lasse Liehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122501/
> -----------------------------------------------------------
>
> (Updated avr. 9, 2015, 2:03 matin)
>
>
> Review request for Build System and Aurélien Gâteau.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Do not call lrelease with -compress
>
> According to Oswald Buddenhagen "it doesn't buy much, and there are some long-standing issues with it".
>
> Qt bug report: https://bugreports.qt.io/browse/QTBUG-44362
>
>
> Diffs
> -----
>
> modules/ECMCreateQmFromPoFiles.cmake 3f134fb
> modules/ECMPoQmTools.cmake 015b7f9
>
> Diff: https://git.reviewboard.kde.org/r/122501/diff/
>
>
> Testing
> -------
>
> Manual testing. Generated qm files fine here.
>
>
> Thanks,
>
> Lasse Liehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150409/4394310a/attachment.html>
More information about the Kde-buildsystem
mailing list