Review Request 120648: Encode the URIs which end up in DTD files

[Andrius da Costa Ribas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
-----------------------------------------------------------



src/CMakeLists.txt (line 20)
<https://git.reviewboard.kde.org/r/120648/#comment53667>

    It's already committed (but there's been a long time since I hadn't build anything), but now I see that DocBookXML4_DTD_DIR is used only inside the "else(NOT WIN32)" part, is this what's been intended? Also, this doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows path "V:" becomes "V%3A" and xmllint fails to recognise it as an absolute path (see below) and CMake would fail to install to such location. (maybe we should prepend it with "file://" ?)
    
    file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102: warning: failed to load external
    ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd"
    %DocBookDTD;


- Andrius da Costa Ribas


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
> 
> (Updated Fev. 28, 2015, 10:02 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
> 
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.
> 
> 
> Diffs
> -----
> 
>   cmake/uriencode.cmake PRE-CREATION 
>   src/CMakeLists.txt 341ecf4 
> 
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
> 
> 
> Testing
> -------
> 
> It compiles, but I can't properly test Mac and Windows scenarios
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150403/450005a2/attachment.html>