Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)
Luigi Toscano
luigi.toscano at tiscali.it
Thu Sep 25 22:56:10 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120324/
-----------------------------------------------------------
(Updated Set. 26, 2014, 12:56 a.m.)
Status
------
This change has been discarded.
Review request for Build System, KDE Frameworks and kdewin.
Repository: kdoctools
Description
-------
Unify most of the CMake code which generates the DTD instead of duplicating the functionalities for WIN32 and non-WIN32 execution. The WIN32 branch only needs to compute the relative path, the rest of the code can be shared.
If accepted, a similar patch can be applied to kdelibs4support.
Diffs
-----
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120324/diff/
Testing
-------
Tested on a Linux-based based system only, needs input from Windows developers.
Thanks,
Luigi Toscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140925/d5695143/attachment.html>
More information about the Kde-buildsystem
mailing list