Review Request 120246: Set CMAKE_INSTALL_SYSCONFDIR to /etc when CMAKE_INSTALL_PREFIX is /usr
Michael Palimaka
kensington at gentoo.org
Fri Sep 19 15:28:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120246/#review66966
-----------------------------------------------------------
+1
- Michael Palimaka
On Sept. 17, 2014, 5:58 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120246/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 5:58 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Bugs: 339120
> http://bugs.kde.org/show_bug.cgi?id=339120
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> When installing to /usr, we should use /etc for configuration. Using /usr/etc does not make sense.
>
>
> Diffs
> -----
>
> kde-modules/KDEInstallDirs.cmake e255e87e12ff1749660ea1c2cc6fdabde9f722a8
> tests/CMakeLists.txt b8fb3b8430521a2e0beea099ce8203fe298132c8
> tests/KDEInstallDirsTest/CMakeLists.txt ad3febe55beb909ce648ebcb3e4fccdf5dd939e9
> tests/KDEInstallDirsTest/usr_vars_defined/CMakeLists.txt PRE-CREATION
> tests/KDEInstallDirsTest/usr_vars_defined/main.c PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120246/diff/
>
>
> Testing
> -------
>
> Unit test created; tests pass.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140919/b11ce9c5/attachment.html>
More information about the Kde-buildsystem
mailing list