Review Request 120229: allow qmldir to follow qt_sys_path

[Rohan Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120229/#review66723
-----------------------------------------------------------

Ship it!


Ship It!

- Rohan Garg


On Sept. 16, 2014, 2:46 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120229/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 2:46 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, Rohan Garg, and Sune Vuorela.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> when running with the KDE_INSTALL_USE_QT_SYS_PATHS option allow QMLDIR in
> KDEInstallDirs to follow whatever is defined by qmake
> 
> this change makes sure that qml plugins will end up in a default Qt path
> when using the super special magic flag.
> 
> 
> Diffs
> -----
> 
>   tests/KDEInstallDirsTest/qt_vars_defined/CMakeLists.txt 40c1cd88b0b8d0280eaf21ca0ef120cd454d1912 
>   kde-modules/KDEInstallDirs.cmake 7fbf6728ff1dcaa330f5b76aa199c7865f329f6d 
> 
> Diff: https://git.reviewboard.kde.org/r/120229/diff/
> 
> 
> Testing
> -------
> 
> without patch:
> solid installs qml plugins to $LIBDIR/qml
> 
> with patch:
> solid installs qml plugins to path returned by qmake -query
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140917/ce30eb6c/attachment.html>