Review Request 120034: FindWayland: Add macros to generate code from XML protocols

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120034/#review66391
-----------------------------------------------------------


The actual code in the functions looks find, but (and sorry to make you rearrange the code again) I think this would be best as two find modules: FindWaylandScanner.cmake and FindQtWaylandScanner.cmake. These should find the executables, providing targets (Wayland::Scanner and Wayland::QtScanner?) if they are found. find_package_handle_standard_args should be used, of course. And the functions would be part of the relevant modules.

Also, you'll need to create documentation links in docs/find-modules. It's fairly straightforward - just look at the other files in there.

Once that's done, don't forget to build the documentation (just `make` if you have Sphinx installed) and check it looks right.

- Alex Merry


On Sept. 6, 2014, 5:28 p.m., Pier Luigi Fiorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120034/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 5:28 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> ECMWayland: Add macros to generate code from XML protocols
> 
> 
> Diffs
> -----
> 
>   modules/ECMWayland.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120034/diff/
> 
> 
> Testing
> -------
> 
> Built my QML Wayland compositor with it
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140913/4d19d1e4/attachment.html>