Review Request 120034: FindWayland: Add macros to generate code from XML protocols

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120034/#review65733
-----------------------------------------------------------



find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/120034/#comment45937>

    s/is/are/



find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/120034/#comment45939>

    Please see other modules for how to format macro/function documentation. In particular, you need double-colons and indentation.



find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/120034/#comment45941>

    Not all projects that do find_package(wayland) will need this. I wonder if maybe the scanner should be a component (see higher up in the file, although you won't be able to depend on ecm_find_package_handle_library_compoments to do magic for you). Alternatively, this could be a separate module.



find-modules/FindWayland.cmake
<https://git.reviewboard.kde.org/r/120034/#comment45940>

    I would prefer keyword arguments (the `_sources` argument can stay as a positional argument, but doesn't actually need an underscore) using cmake_parse_arguments().


- Alex Merry


On Sept. 2, 2014, 10:21 a.m., Pier Luigi Fiorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120034/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 10:21 a.m.)
> 
> 
> Review request for Extra Cmake Modules, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> FindWayland: Add macros to generate code from XML protocols
> 
> 
> Diffs
> -----
> 
>   find-modules/FindWayland.cmake 11716f04444497db380e94b3d8ef69f41546f789 
> 
> Diff: https://git.reviewboard.kde.org/r/120034/diff/
> 
> 
> Testing
> -------
> 
> Built my QML Wayland compositor with it
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140902/8aae9136/attachment.html>