Review Request 119798: Generating PkgConfig files from ECM

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 1:53 p.m.)


Review request for Build System, KDE Frameworks and Harald Sitter.


Repository: extra-cmake-modules


Description
-------

So we decided we wanted those .pc files, so I created a small script that generates one, I haven't used pc in the past, so feedback is welcome.


Diffs (updated)
-----

  modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION 
  tests/CMakeLists.txt 65de038 
  tests/ECMGeneratePkgConfigFile/CMakeLists.txt PRE-CREATION 
  tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc PRE-CREATION 
  tests/ECMGeneratePkgConfigFile/run_test.cmake.config PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119798/diff/


Testing
-------

I added it in KCoreAddons, this is the patch:
diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt
index 26eb5a1..3a07d1c 100644
--- src/lib/CMakeLists.txt
+++ src/lib/CMakeLists.txt
@@ -188,4 +188,6 @@ install(FILES
 
 include(ECMGeneratePriFile)
 ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)
+ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons INSTALL)
 install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})

This is the result, on my system:

Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons 
Requires: Qt5Core


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140901/9649565d/attachment.html>