Review Request 120648: Encode the URIs which end up in DTD files
Marko Käning
mk-lists at email.de
Thu Oct 23 22:04:05 UTC 2014
> On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote:
> > These are both RRs for KF5?
>
> Luigi Toscano wrote:
> Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it?
>
> René J.V. Bertin wrote:
> You say that this is for "when the path contains spaces, as it happens on MacOSX builds."
> I haven't run into this, can you give an example? What path, and building what?
>
> I'd say that people installing KDE on OS X are aware enough of the "dangers" not to use spaces in KDE related paths (I for one certainly avoid them), but I may be overlooking certain scenarios.
>
> Luigi Toscano wrote:
> Please ask Marko, he hit this problem when testing KDocTools/KF5.
René, the path would be "/Library/Application Support" for instance! :-)
- Marko
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68675
-----------------------------------------------------------
On Oct. 20, 2014, 2:12 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 2:12 a.m.)
>
>
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
>
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.
>
>
> Diffs
> -----
>
> cmake/uriencode.cmake PRE-CREATION
> src/CMakeLists.txt 341ecf4
>
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
>
>
> Testing
> -------
>
> It compiles, but I can't properly test Mac and Windows scenarios
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141023/ffb611c2/attachment-0001.html>
More information about the Kde-buildsystem
mailing list