Review Request 120655: If find_dependency() fails, so should the Config file it is in

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120655/#review68742
-----------------------------------------------------------

Ship it!


Confirmed working as expected with the patch.

- Harald Sitter


On Oct. 19, 2014, 6:56 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120655/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 6:56 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Harald Sitter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> If find_dependency() fails, so should the Config file it is in
> 
> This matches the behaviour of CMake's version of this macro, which we defer to in CMake 3.0 and later.
> 
> 
> Diffs
> -----
> 
>   modules/ECMPackageConfigHelpers.cmake da65c3eac39edb0b00a2172af7b58f310d967722 
> 
> Diff: https://git.reviewboard.kde.org/r/120655/diff/
> 
> 
> Testing
> -------
> 
> Ran `make test`. Built everything KF5-related using CMake 2.8.12 and ECM with this change. Haven't got round to trying to remove a dep and running CMake.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141020/70ad6e14/attachment.html>