Review Request 120648: Encode the URIs which end up in DTD files
Luigi Toscano
luigi.toscano at tiscali.it
Mon Oct 20 00:12:44 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 2:12 a.m.)
Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
Changes
-------
Encoding for double quote added; colon is now encoded as well.
Repository: kdoctools
Description
-------
The URI need to be encoded, because some valid characters for
filenames are not valid according RFC 2396.
Easy way to trigger the issue: when the path contains spaces,
as it happens on MacOSX builds.
See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.
Diffs (updated)
-----
cmake/uriencode.cmake PRE-CREATION
src/CMakeLists.txt 341ecf4
Diff: https://git.reviewboard.kde.org/r/120648/diff/
Testing
-------
It compiles, but I can't properly test Mac and Windows scenarios
Thanks,
Luigi Toscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141020/2427edd1/attachment.html>
More information about the Kde-buildsystem
mailing list