Review Request 120034: Wayland and QtWayland protocol scanners

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120034/#review68695
-----------------------------------------------------------


Sorry, just one more round, then I promise we're done :-)


find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47894>

    You definitely want "AND QtWaylandScanner_FOUND)", not "AND ${QtWaylandScanner_FOUND})". if() expects variable names as arguments, and expands them if it can.



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47895>

    These five lines are actually equivalent to just one:
        set(_prefix "${ARGS_PREFIX}")



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47896>

    See above.


- Alex Merry


On Oct. 19, 2014, 9:50 a.m., Pier Luigi Fiorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120034/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 9:50 a.m.)
> 
> 
> Review request for Extra Cmake Modules, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a couple of find modules for wayland-scanner and qtwaylandscanner.
> These modules find the respective executables and create a target that
> points to the executable.
>     
> Targets are respectively Wayland::Scanner and Wayland::QtScanner.
> 
> There are also macros to generate C protocols with wayland-scanner and
> C++ wrappers with qtwaylandscanner.
> 
> 
> Diffs
> -----
> 
>   docs/find-module/FindQtWaylandScanner.rst PRE-CREATION 
>   docs/find-module/FindWaylandScanner.rst PRE-CREATION 
>   find-modules/FindQtWaylandScanner.cmake PRE-CREATION 
>   find-modules/FindWaylandScanner.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120034/diff/
> 
> 
> Testing
> -------
> 
> Built my QML Wayland compositor with it and KWayland for FindWaylandScanner
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141019/b762c323/attachment.html>