Review Request 120648: Encode the URIs which end up in DTD files

[René J.V. Bertin]

> On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote:
> > These are both RRs for KF5?
> 
> Luigi Toscano wrote:
>     Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it?

You say that this is for "when the path contains spaces, as it happens on MacOSX builds."
I haven't run into this, can you give an example? What path, and building what?

I'd say that people installing KDE on OS X are aware enough of the "dangers" not to use spaces in KDE related paths (I for one certainly avoid them), but I may be overlooking certain scenarios.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review68675
-----------------------------------------------------------


On Oct. 18, 2014, 5:50 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120648/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2014, 5:50 p.m.)
> 
> 
> Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> The URI need to be encoded, because some valid characters for
> filenames are not valid according RFC 2396.
> Easy way to trigger the issue: when the path contains spaces,
> as it happens on MacOSX builds.
> 
> See also https://git.reviewboard.kde.org/r/120649/ for the twin review on kdelibs4support.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 341ecf4 
>   cmake/uriencode.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120648/diff/
> 
> 
> Testing
> -------
> 
> It compiles, but I can't properly test Mac and Windows scenarios
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141018/3f875606/attachment.html>