Review Request 120481: Do not skip searching for X11 and Wayland modules on Windows

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120481/#review67983
-----------------------------------------------------------


Please also get the feedback from the windows developers.

For Wayland I'm fine with the change - it should not exist for Windows and yes it should fail in that case. For the XCB one I'm a little bit doubtful in what it might result in. XCB should be available on Windows through the cygwin project, so in theory it might be possible to compile on Windows (and OSX) with XCB support. My fear is that incorrect usage downstream might result in undefined behavior if XCB is found. We still have too many incorrect ports from the old #ifdef Q_WS_X11 without a proper runtime check. So on that part we need the opinion of the Windows developers on how dangerous this could be.

- Martin Gräßlin


On Oct. 3, 2014, 6:19 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120481/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 6:19 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> While the search is unlikely to succeed on Windows, having different
> behaviour between the platforms (eg: find_package(Wayland REQUIRED) was
> not fatal on Windows, even though Wayland_FOUND would always be FALSE)
> is not ideal, and if someone did port them to Windows for some reason,
> the find modules should support that.
> 
> If applications actually want different behaviour between platforms
> (like requiring a module on Unix, but not on Windows), they should
> implement that logic themselves (since they will have to deal with
> targets not being defined, etc, anyway).
> 
> 
> Diffs
> -----
> 
>   find-modules/FindEGL.cmake f1962b9abc7fef381efe073c1ce18379ab2a47da 
>   find-modules/FindWayland.cmake 11716f04444497db380e94b3d8ef69f41546f789 
>   find-modules/FindX11_XCB.cmake 05d18d5adfd197fea4f0c7defbe53da776ebac79 
>   find-modules/FindXCB.cmake 76d69fd790fb4831abd8a8351a684b97f6816081 
> 
> Diff: https://git.reviewboard.kde.org/r/120481/diff/
> 
> 
> Testing
> -------
> 
> None whatsoever, since I want Martin's feedback on the idea first.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141006/54c50681/attachment.html>