Review Request 120034: Wayland and QtWayland protocol scanners

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120034/#review67845
-----------------------------------------------------------



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47265>

    No need to have both qtwaylandscanner_executable and QtWaylandScanner_EXECUTABLE. Just use QtWaylandScanner_EXECUTABLE (there's no point it containing the target name - if people want to use the target, they will use the target, but if they *actually* want the execuable path, they can use this variable).
    
    Also, call
    
        mark_as_advanced(QtWaylandScanner_EXECUTABLE)



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47260>

    Fatal? Really? It's only fatal if QtWaylandScanner_FIND_REQUIRED was set, and find_package_handle_standard_args will deal with that.



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47261>

    Let find_package_handle_standard_args deal with this variable.



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47264>

    Set up this *after* find_package_handle_standard_args, which will set QtWaylandScanner_FOUND for you, and add QtWaylandScanner_FOUND to the if()



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47266>

    See above - let find_program set this.



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47258>

    This is REQUIRED. And maybe also QUIET. You should also note that WaylandScanner is required and will be searched for in the function documention.



find-modules/FindQtWaylandScanner.cmake
<https://git.reviewboard.kde.org/r/120034/#comment47259>

    REQUIRED (+ QUIET?) + docs (see above)


Most of the issues I've noted with FindQtWaylandScanner.cmake also apply to FindWaylandScanner.cmake.

- Alex Merry


On Sept. 24, 2014, 5:35 a.m., Pier Luigi Fiorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120034/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 5:35 a.m.)
> 
> 
> Review request for Extra Cmake Modules, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a couple of find modules for wayland-scanner and qtwaylandscanner.
> These modules find the respective executables and create a target that
> points to the executable.
>     
> Targets are respectively Wayland::Scanner and Wayland::QtScanner.
> 
> There are also macros to generate C protocols with wayland-scanner and
> C++ wrappers with qtwaylandscanner.
> 
> 
> Diffs
> -----
> 
>   docs/find-module/FindQtWaylandScanner.rst PRE-CREATION 
>   docs/find-module/FindWaylandScanner.rst PRE-CREATION 
>   find-modules/FindQtWaylandScanner.cmake PRE-CREATION 
>   find-modules/FindWaylandScanner.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120034/diff/
> 
> 
> Testing
> -------
> 
> Built my QML Wayland compositor with it and KWayland for FindWaylandScanner
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141003/360cd808/attachment-0001.html>