Review Request 118114: More complete testing of ECMPoQmTools

Alex Merry alex.merry at kde.org
Tue May 13 14:54:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118114/#review57880
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On May 13, 2014, 1:53 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118114/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 1:53 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> - Test calling ecm_process_po_files_as_qm() without INSTALL_DESTINATION argument
> - Test calling ecm_install_po_files_as_qm() with CMAKE_INSTALL_LOCALEDIR set and with LOCALE_INSTALL_DIR set
> 
> 
> Diffs
> -----
> 
>   tests/ECMPoQmToolsTest/CMakeLists.txt eabf2b8 
>   tests/ECMPoQmToolsTest/check_tree.cmake.in 71cbaa8 
>   tests/ECMPoQmToolsTest/only-process.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/po-custom-dir1/es/custom-dir1-install-test.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/po-custom-dir1/fr/custom-dir1-install-test.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/po-custom-dir2/es/custom-dir2-install-test.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/po-custom-dir2/fr/custom-dir2-install-test.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/process-and-install.po PRE-CREATION 
>   tests/ECMPoQmToolsTest/test.po 107d1b0 
> 
> Diff: https://git.reviewboard.kde.org/r/118114/diff/
> 
> 
> Testing
> -------
> 
> ecm tests still pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140513/70dfbb50/attachment.html>


More information about the Kde-buildsystem mailing list