Review Request 118057: Use CMAKE_INSTALL_FOODIR style variables for KDEInstallDirs

Kevin Ottens ervin at kde.org
Mon May 12 15:21:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118057/#review57788
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On May 8, 2014, 8:48 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118057/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 8:48 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This matches how CMake's GNUInstallDirs does things. The documentation is  not yet updated, as this is an RFC, really. The old variable names still work, both when passed to the CMake command and when used in CMake scripts (the code keeps the old and new variables in sync).
> 
> I took the opportunity to version the variable names for directories that are themselves versioned, which should help the transition to KF6.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake cadbba130fb282faa485594a420210710c8f951c 
> 
> Diff: https://git.reviewboard.kde.org/r/118057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140512/3773e128/attachment.html>


More information about the Kde-buildsystem mailing list