[extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

[Alex Richardson]

Am Montag, 12. Mai 2014, 13:27:21 schrieb Alex Merry:
> > But other than that, I don't mind if the prefixes get removed from the 
> > frameworks's tests.
> >
> > 
> >
> > In any case, I didn't expect the executable name to be called e.g. 
> > xmlgui-kxmlgui_unittest. That is quite odd and unexpected.
> 
> I agree that it's weird and unnecessary in the frameworks, but that can
> be solved by removing the NAME_PREFIX argument.
> 
> For the macro, though, the question is what is the purpose of the
> prefix? Is it just to make things easier for humans reading the output
> of "make test", or should it provide actual namespacing (so that tests
> don't actually tread on each other's toes in large codebases). And if we
> think of something like KIO's "globaltest", having the executable
> kiocore-globaltest isn't odd, and it seems reasonable that multiple code
> sections in large codebases might want tests named "globaltest".
> 
> Alex

I guess this is only useful on Windows where all executables that are built 
land in the same directory. Having them prefixed makes sure there is no 
conflict there. But otherwise it serves very little purpose having the targets 
with the prefix.

Regards,
Alex