Review Request 117965: use the correct global variables
Alex Merry
alex.merry at kde.org
Sat May 3 14:54:29 UTC 2014
> On May 3, 2014, 10:10 a.m., Alex Merry wrote:
> > kde-modules/KDECMakeSettings.cmake, lines 170-176
> > <https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170>
> >
> > Now the comment doesn't match the code - which is correct?
>
> Patrick Spendrin wrote:
> The fix here is that RUNTIME_OUTPUT_DIRECTORY -> CMAKE_RUNTIME_OUTPUT_DIRECTORY because the first one is a target property and not a global variable. I also modified the CMAKE_ARCHIVE|LIBRARY_OUTPUT_DIRECTORY's values, but that isn't strictly required.
>
> Patrick von Reth wrote:
> yes but you install the dll to ${CMAKE_BINARY_DIR}/lib
>
> " set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/lib")"
>
> Patrick Spendrin wrote:
> No, the dll is RUNTIME so it goes into /bin.
Well, I would view the comment as misleading, then. The code isn't combining the executable and dll locations, CMake does that anyway.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57180
-----------------------------------------------------------
On May 2, 2014, 10:53 p.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117965/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 10:53 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> use the correct global variables
>
>
> Diffs
> -----
>
> kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242
>
> Diff: https://git.reviewboard.kde.org/r/117965/diff/
>
>
> Testing
> -------
>
> windows
>
>
> Thanks,
>
> Patrick Spendrin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140503/2b91f756/attachment.html>
More information about the Kde-buildsystem
mailing list