Review Request 117965: use the correct global variables

Alex Merry alex.merry at kde.org
Sat May 3 10:10:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117965/#review57180
-----------------------------------------------------------



kde-modules/KDECMakeSettings.cmake
<https://git.reviewboard.kde.org/r/117965/#comment39860>

    Now the comment doesn't match the code - which is correct?


- Alex Merry


On May 2, 2014, 10:53 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117965/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 10:53 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> use the correct global variables
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 
> 
> Diff: https://git.reviewboard.kde.org/r/117965/diff/
> 
> 
> Testing
> -------
> 
> windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140503/3ebe471a/attachment-0001.html>


More information about the Kde-buildsystem mailing list