Review Request 117052: Add ECMSetupQtTranslations

Alex Merry alex.merry at kde.org
Fri Mar 28 11:15:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54424
-----------------------------------------------------------



modules/ECMSetupQtTranslations.cmake
<https://git.reviewboard.kde.org/r/117052/#comment38079>

    "POT_NAME is the name of the .pot file for the project.  This file must be in PO_DIR."



modules/ECMSetupQtTranslations.cmake
<https://git.reviewboard.kde.org/r/117052/#comment38077>

    You should probably prefix these with _ecm_sqt



modules/ECMSetupQtTranslations.cmake
<https://git.reviewboard.kde.org/r/117052/#comment38078>

    likewise: _ecm_sqts prefix


- Alex Merry


On March 28, 2014, 9:45 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117052/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 9:45 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This simplifies translation handling for frameworks using Qt translation system.
> 
> 
> Diffs
> -----
> 
>   modules/ECMSetupQtTranslations.cmake PRE-CREATION 
>   modules/ECMTrLoader.cpp.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117052/diff/
> 
> 
> Testing
> -------
> 
> Here is a patch which make kbookmarks use it: http://agateau.com/tmp/kbookmarks-tr.diff . The necessary changes for the Messages.sh part of the patch are being reviewed for inclusion in the l10n-kde4 repository.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140328/1b1387b4/attachment-0001.html>


More information about the Kde-buildsystem mailing list