Review Request 117052: Add ECMSetupQtTranslations

[Alex Merry]

> On March 27, 2014, 8:31 p.m., Alex Merry wrote:
> > modules/ECMTrLoader.cpp.in, line 19
> > <https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19>
> >
> >     QLatin1String() when you're using +
> 
> Aleix Pol Gonzalez wrote:
>     Why? That doesn't make sense on my book.

*Goes and reads the docs again*

Ah, I think you're right there.  QLatin1String is good for things that never get converted, like ==, but otherwise the Literal works better.

You can just drop this issue.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117052/#review54369
-----------------------------------------------------------


On March 27, 2014, 3:26 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117052/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 3:26 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This simplifies translation handling for frameworks using Qt translation system.
> 
> 
> Diffs
> -----
> 
>   modules/ECMSetupQtTranslations.cmake PRE-CREATION 
>   modules/ECMTrLoader.cpp.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117052/diff/
> 
> 
> Testing
> -------
> 
> Here is a patch which make kbookmarks use it: http://agateau.com/tmp/kbookmarks-tr.diff . The necessary changes for the Messages.sh part of the patch are being reviewed for inclusion in the l10n-kde4 repository.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140327/76d8422d/attachment.html>