Review Request 116653: Create ECMFindModuleHelpers module for common find-module code

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116653/#review53184
-----------------------------------------------------------

Ship it!


Not that I'm really knowledgeable, but since no one else seems to pay attention to this one, let's not block it further. :-)

- Kevin Ottens


On March 11, 2014, 12:32 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116653/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 12:32 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Create ECMFindModuleHelpers module for common find-module code
> 
> This currently mostly contains macros for handling components;
> FindWayland and FindXCB are ported to use this module, which comes with
> various improvements for them.
> 
> 
> Diffs
> -----
> 
>   docs/writing-find-modules.md 4f6a9cd68959e51b0c26a18c4c9d0633dd9f1c76 
>   find-modules/FindWayland.cmake a121de9f8adda1e035b0f8e8401be26a45b61af4 
>   find-modules/FindXCB.cmake eb3075885bc408fc4c213516a387dfcd0e75cb8b 
>   modules/ECMFindModuleHelpers.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116653/diff/
> 
> 
> Testing
> -------
> 
> Tested various configurations with a test CMakeLists.txt file, including with various include files missing.
> 
> Configured and built kwindowsystem and kde-workspace.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140317/9ef59982/attachment.html>