Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

Aleix Pol Gonzalez aleixpol at
Tue Mar 11 11:05:10 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated March 11, 2014, 11:05 a.m.)

Review request for Build System and KDE Frameworks.


Don't center the replace on /. Actually only allow alphanumeric characters on the target name and replace the rest with -.

This should be more flexible.

Repository: kdoctools


While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename).

I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something?

Diffs (updated)

  KF5DocToolsMacros.cmake 6567b67 



Now kde-runtime documentation builds.


Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-buildsystem mailing list