Review Request 116650: Give unique names to the targets created by KDocToolsMacros.cmake

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116650/
-----------------------------------------------------------

(Updated March 11, 2014, 11:05 a.m.)


Review request for Build System and KDE Frameworks.


Changes
-------

Don't center the replace on /. Actually only allow alphanumeric characters on the target name and replace the rest with -.

This should be more flexible.


Repository: kdoctools


Description
-------

While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename).

I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something?


Diffs (updated)
-----

  KF5DocToolsMacros.cmake 6567b67 

Diff: https://git.reviewboard.kde.org/r/116650/diff/


Testing
-------

Now kde-runtime documentation builds.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140311/2d0f8f57/attachment-0001.html>