Review Request 116598: Check versions for individual components of Wayland

[Alex Merry]

> On March 5, 2014, 12:31 p.m., Alex Merry wrote:
> > Note that find_package(Wayland COMPONENTS Client Egl) *should* fail.  What shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
> 
> Alex Merry wrote:
>     I hadn't realised that about pkg_check_modules(), though.  I'll have to update the docs I wrote.
> 
> Aurélien Gâteau wrote:
>     Oh, I didn't know about OPTIONAL_COMPONENTS. Anyway, the fix is here to ensure early fail: without it one could not check for a minimum version of Wayland.

I think the last fphsa call should cause the version to be checked.  The version-checking change you made should only make any difference if you have components with different versions installed.  Your change just makes it fail sooner.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review52067
-----------------------------------------------------------


On March 5, 2014, 9 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116598/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 9 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> First part of the diff makes sure find_package_handle_standard_args() gets a version number to check against.
> 
> Second part ensures we get proper results from pkg-config even if not all components are available. find_package(Wayland COMPONENTS Client Egl) was failing for me because I have Client installed but not Egl, causing pkg_check_modules() to not set any PKG_Wayland_${comp} variable.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindWayland.cmake 21014fc 
> 
> Diff: https://git.reviewboard.kde.org/r/116598/diff/
> 
> 
> Testing
> -------
> 
> Together with a change for kde-workspace, it fixes the build of kde-workspace on my system with wayland-client 1.1 and no wayland-egl.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140305/cf577b8e/attachment-0001.html>