Review Request 116080: find_dependency: Update to match CMake's version

Commit Hook null at kde.org
Sun Mar 2 11:48:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116080/#review51626
-----------------------------------------------------------


This review has been submitted with commit e3d7a3e98d711afa0dbf64c59bdb58030179687a by Alex Merry to branch master.

- Commit Hook


On Feb. 26, 2014, 3:07 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116080/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 3:07 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> find_dependency: Update to match CMake's version
> 
> Specifically, we namespace the variables to avoid conflicts, and make
> the version argument optional.
> 
> 
> Diffs
> -----
> 
>   modules/ECMPackageConfigHelpers.cmake ee6bfd6f7e79a9f842ad6d34931a9273c2ee3c4f 
> 
> Diff: https://git.reviewboard.kde.org/r/116080/diff/
> 
> 
> Testing
> -------
> 
> kdesrc-build with clean build and install dirs successful, using CMake 2.8.12 (and so using this version of find_dependency, rather than the one shipped with CMake 3.0).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140302/d1b5566d/attachment.html>


More information about the Kde-buildsystem mailing list