Review Request 118498: Make ECM language-independent again, but make the tests use C

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118498/#review60285
-----------------------------------------------------------

Ship it!


Looks fine to me.

- Kevin Ottens


On June 15, 2014, 4:13 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118498/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 4:13 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, Christophe Giboudeaux, Nicolás Alvarez, and Allen Winter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Provide an option to exclude the tests
> 
> While the tests in ECM are not "built" as such (at least, not until they
> are run), disabling the tests might be desirable to avoid the compiler
> checks and to make the whole build process architecture-independent.
> 
> Make ECM language-independent again, but make the tests use C
> 
> Setting the language for ECM's project() call to C had unanticipated
> side-effects - notably that the installed version file required the
> architecture to match the one used at build time.
> 
> Instead, we make the tests a sub-project, setting up C as the language
> there (since most of the tests do use C, albeit slightly indirectly).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt df0759f18f1ed091b43128c1c5844aead560fe5b 
>   tests/CMakeLists.txt dfcc252a4e723d7376f87153adcd23d00dbc7846 
> 
> Diff: https://git.reviewboard.kde.org/r/118498/diff/
> 
> 
> Testing
> -------
> 
> Configures properly, tests pass. Visually inspected ECMConfigVersion.cmake file to see that it will return before the architecture check.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140617/0cae9ec0/attachment.html>