Review Request 119230: Import FindOpenGLES from kwin.

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119230/#review62126
-----------------------------------------------------------


I'm quite honest here: I wrote the Find module and it's not even 1 % close to the quality we need for ECM. So from my side a -2 to importing.

- Martin Gräßlin


On July 11, 2014, 12:56 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119230/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 12:56 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Import FindOpenGLES from kwin.
> 
> Besides kwin it's also needed for kinfocenter and plasma-desktop.
> 
> 
> This is a follow-up of https://git.reviewboard.kde.org/r/119227/.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindOpenGLES.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140711/e530f0a8/attachment.html>