Review Request 119198: Don't search default paths when finding lconvert.
Michael Palimaka
kensington at gentoo.org
Wed Jul 9 14:12:20 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119198/
-----------------------------------------------------------
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Repository: extra-cmake-modules
Description
-------
Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one
will be used instead of the one alongside Qt5::lrelease. This could cause Qt4
lconvert to be incorrectly used on some systems.
Diffs
-----
modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6
modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af
Diff: https://git.reviewboard.kde.org/r/119198/diff/
Testing
-------
When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin.
Thanks,
Michael Palimaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140709/476baf23/attachment.html>
More information about the Kde-buildsystem
mailing list