Review Request 115372: Improve the compiler version checks
Alexander Richardson
arichardson.kde at googlemail.com
Wed Jan 29 17:10:15 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115372/#review48563
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Richardson
On Jan. 29, 2014, 2:20 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115372/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 2:20 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Improve the compiler version checks
>
> - Only warn if the compiler is not recent enough (it may still work...)
> - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt
> - Add checks for Windows (both MSVC and MinGW)
> - Add check for Clang
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake bcc11284d36830963af66f203bc5ea0397afa611
>
> Diff: https://git.reviewboard.kde.org/r/115372/diff/
>
>
> Testing
> -------
>
> Built KCoreAddons with gcc 4.8.2 on Linux. Got no warning.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140129/cbdba717/attachment-0001.html>
More information about the Kde-buildsystem
mailing list