Review Request 115376: KDE_SOURCE_FILES_ENABLE_EXCEPTIONS: Handle case where COMPILE_FLAGS is not set
Alex Merry
kde at randomguy3.me.uk
Wed Jan 29 13:29:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115376/#review48533
-----------------------------------------------------------
Ship it!
kde-modules/KDECompilerSettings.cmake
<https://git.reviewboard.kde.org/r/115376/#comment34300>
I would have gone for
if (NOT flags)
# CMake can give NOTFOUND as a result
set(flags)
endif()
which may be more resilient to possible changes in the implementation of get_source_file_property, but I'm not that fussed either way.
- Alex Merry
On Jan. 29, 2014, 10:17 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115376/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 10:17 a.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> When COMPILE_FLAGS is not set, get_source_file_property(flags ${source_file} COMPILEFLAGS) set flags to "NOTFOUND". Leading to interesting build failures in kde-runtime when we then set flags to "NOTFOUND -fexceptions", see http://build.kde.org/job/kde-runtime_frameworks_qt5/58/
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake 6b7ab4e
>
> Diff: https://git.reviewboard.kde.org/r/115376/diff/
>
>
> Testing
> -------
>
> Built kde-runtime successfully.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140129/50340a65/attachment.html>
More information about the Kde-buildsystem
mailing list