Review Request 115360: Remove the allocator and visibility check

Alex Merry kde at randomguy3.me.uk
Tue Jan 28 22:43:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115360/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 10:43 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

Remove a stray set() call.


Repository: extra-cmake-modules


Description
-------

Remove the allocator and visibility check

I am reasonably sure the allocator check is out of date, given our
minimum GCC version, and it was not used for anything interesting
anyway.

The visibility check will not be performed in practice, as this file
will almost always be included before any check for Qt.


Diffs (updated)
-----

  kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 

Diff: https://git.reviewboard.kde.org/r/115360/diff/


Testing
-------

Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140128/08a2b5b0/attachment.html>


More information about the Kde-buildsystem mailing list