Review Request 115360: Remove the allocator and visibility check

Alex Merry kde at randomguy3.me.uk
Tue Jan 28 16:41:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115360/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 4:41 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

Remove the allocator and visibility check

I am reasonably sure the allocator check is out of date, given our
minimum GCC version, and it was not used for anything interesting
anyway.

The visibility check will not be performed in practice, as this file
will almost always be included before any check for Qt.


Diffs
-----

  kde-modules/KDECompilerSettings.cmake 3419cb1266c63f9cdec0501ae340aabe7c0b6096 

Diff: https://git.reviewboard.kde.org/r/115360/diff/


Testing (updated)
-------

KCoreAddons still configures and compiles (GCC 4.8.2 20131219; Linux with glibc 2.18).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140128/dd80a2aa/attachment.html>


More information about the Kde-buildsystem mailing list