Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

Kevin Ottens ervin at kde.org
Mon Jan 27 07:25:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115294/#review48334
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Jan. 24, 2014, 2:45 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115294/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 2:45 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add system API feature macros to CMAKE_REQUIRED_DEFINES
> 
> Various defines we set affect the API offered by the system; subsequent
> CMake configure checks should happen in a matching environment.
> 
> 
> See also: https://git.reviewboard.kde.org/r/115295/ and https://git.reviewboard.kde.org/r/115296/
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 7891136124ced0273ff05bbe521d93acc22a00f7 
> 
> Diff: https://git.reviewboard.kde.org/r/115294/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140127/76b6170c/attachment.html>


More information about the Kde-buildsystem mailing list