Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

Alex Merry kde at randomguy3.me.uk
Thu Jan 23 18:18:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115268/
-----------------------------------------------------------

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

kde_enable_exceptions() essentially does what
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}  ${KDE_ENABLE_EXCEPTIONS}")
used to do.  kde_target_enable_exceptions does it on a per-target basis.


Diffs
-----

  kde-modules/KDECompilerSettings.cmake 7891136124ced0273ff05bbe521d93acc22a00f7 

Diff: https://git.reviewboard.kde.org/r/115268/diff/


Testing
-------

Both macros tested with ThreadWeaver (compilation and tests).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140123/5c6bf39e/attachment-0001.html>


More information about the Kde-buildsystem mailing list