Review Request 115211: Mark target created by ecm_add_test as non GUI by default

[Nicolás Alvarez]

> On Jan. 22, 2014, 9:08 a.m., Alex Merry wrote:
> > This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets).
> 
> Aleix Pol Gonzalez wrote:
>     Well, we can't change the default, can we?
> 
> Alex Merry wrote:
>     I don't understand what you mean.
> 
> Aleix Pol Gonzalez wrote:
>     If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say.
>     
>     (TBH, it seems to me cmake shouldn't know about that at all, but I take it as just a limitation on Windows (and Android))
> 
> Alex Merry wrote:
>     We have it because we call set(CMAKE_WIN32_EXECUTABLE ON) in KDECMakeSettings.cmake.  CMake documentation is unforthcoming about the default in the absence of that setting, but I think it is off.

A "non-GUI" (console) executable can still display widgets.


- Nicolás


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115211/#review48009
-----------------------------------------------------------


On Jan. 22, 2014, 11:54 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115211/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 11:54 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Mark target created by ecm_add_test as non GUI by default
> 
> This behaviour can be overriden by passing the GUI flag to the command
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e 
> 
> Diff: https://git.reviewboard.kde.org/r/115211/diff/
> 
> 
> Testing
> -------
> 
> Oketeta unit tests wouldn't build on windows before this commit, now they do
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140122/4797541c/attachment.html>