Review Request 114898: Remove use of obsolete add_compiler_export_flags

[Alexander Richardson]

> On Jan. 7, 2014, 8:46 p.m., Commit Hook wrote:
> > This review has been submitted with commit 676e746b78d8b6ada47dd15fd706d0deb9996e45 by Alex Merry to branch master.

A bit late, but how about adding the include(GenerateExportHeader) to KDECMakeSettings.cmake, this way the frameworks don't have to be updated.
I guess most users of KDECMakeSettings will need GenerateExportHeader and even if it is uneeded I doubt it has any noticeable impact on the configure time.

I think it would be nice in order to reduce the amount of CMake boilerplate for KDE applications/libraries.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898/#review47000
-----------------------------------------------------------


On Jan. 7, 2014, 8:46 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114898/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 8:46 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Remove use of obsolete add_compiler_export_flags
> 
> Set CMAKE_CXX_VISIBILITY_PRESET and CMAKE_VISIBILITY_INLINES instead
> (which sets the default for all targets).
> 
> Note that the removal of include(GenerateExportHeader) means that this
> will have to be explicitly included in the CMakeLists.txt of the
> frameworks (as they use generate_export_header).
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 72824e166d03dcc2d089814dc121f08ba998974a 
> 
> Diff: https://git.reviewboard.kde.org/r/114898/diff/
> 
> 
> Testing
> -------
> 
> Threadweaver builds, once include(GenerateExportHeader) is added to its CMakeLists.txt, and properly passes -fvisibility=hidden -fvisibility-inlines-hidden to the library code (although not to the test code).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140107/dc1407b6/attachment-0001.html>