ecm_setup_version (Re: [karchive] /: Show how qmake integration can be done.)

[David Faure]

On Sunday 05 January 2014 20:54:33 David Faure wrote:
> On Sunday 05 January 2014 20:30:35 Alexander Neundorf wrote:
> > (...without looking at the replies) I wouldn't do that, IMO too much
> > "magic" going on.
> > Why should a function called ecm_setup_version() set variables called
> > FRAMEWORK_SOMETHING ?
> > "framework" as used in this context means framework as used here in KDE.
> > ecm_setup_version() is not KDE specific.
> 
> OK, so bad naming - what about it sets
> ECM_SETUP_VERSION_MAJOR/MINOR/PATCH/STRING ?
> or
> PROJECT_VERSION_* ?

We both arrived at PROJECT_VERSION_*, so how about this patch, to start with?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: project_version.diff
Type: text/x-patch
Size: 2200 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140107/e247788e/attachment.diff>