Review Request 116046: Improve FindXCB

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116046/#review50822
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Merry


On Feb. 25, 2014, 1:45 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116046/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 1:45 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Improve FindXCB
> 
>  * define imported targets for all components
>  * add version information
>  * print message on Windows
>  * add package properties
>  * use handle components
> 
> 
> Diffs
> -----
> 
>   find-modules/FindXCB.cmake 823d1678fa049c607586e0c43835c9e6d36ea982 
> 
> Diff: https://git.reviewboard.kde.org/r/116046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140225/7872b6e2/attachment-0001.html>