Review Request 116025: Add documentation about writing find modules

Martin Gräßlin mgraesslin at kde.org
Mon Feb 24 17:41:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116025/#review50727
-----------------------------------------------------------


great work! I will happily test it tomorrow for fixing my two review requests.


docs/writing-find-modules.md
<https://git.reviewboard.kde.org/r/116025/#comment35612>

    s/is/if



docs/writing-find-modules.md
<https://git.reviewboard.kde.org/r/116025/#comment35613>

    suggestion: add the recommended license notice for ecm


- Martin Gräßlin


On Feb. 24, 2014, 6:02 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116025/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 6:02 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add documentation about writing find modules
> 
> 
> Diffs
> -----
> 
>   README.md 85b97b7fa003282e1eeb1113c4668a9b73e3f731 
>   docs/writing-find-modules.md PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140224/3cab5b92/attachment.html>


More information about the Kde-buildsystem mailing list